CVE-2023-34449 – ink! vulnerable to incorrect decoding of storage value when using `DelegateCall`

https://notcve.org/view.php?id=CVE-2023-34449

ink! is an embedded domain specific language to write smart contracts in Rust for blockchains built on the Substrate framework. Starting in version 4.0.0 and prior to version 4.2.1, the return value when using delegate call mechanics, either through `CallBuilder::delegate` or `ink_env::invoke_contract_delegate`, is decoded incorrectly. This bug was related to the mechanics around decoding a call's return buffer, which was changed as part of pull request 1450. Since this feature was only released in ink! • https://docs.rs/ink_env/4.2.0/ink_env/call/struct.CallBuilder.html#method.delegate https://docs.rs/ink_env/4.2.0/ink_env/fn.invoke_contract_delegate.html https://github.com/paritytech/ink/commit/f1407ee9f87e5f64d467a22d26ee88f61db7f3db https://github.com/paritytech/ink/pull/1450 https://github.com/paritytech/ink/security/advisories/GHSA-853p-5678-hv8f • CWE-253: Incorrect Check of Function Return Value CWE-754: Improper Check for Unusual or Exceptional Conditions •